Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement directory path redirection(#19) #36

Merged
merged 2 commits into from
Oct 16, 2022
Merged

feat: Implement directory path redirection(#19) #36

merged 2 commits into from
Oct 16, 2022

Conversation

hhkim0729
Copy link
Collaborator

@hhkim0729 hhkim0729 commented Oct 16, 2022 •
edited
Loading

작업 내용

리뷰어에게

  • 원칙적으로 각 요청과 응답은 독립적이어야 합니다. 그러나 각 요청에서 독립적인 filePath, OriginalHeader, OriginalBody를 Worker에서 관리함으로서 이전에 처리했던 요청의 흔적이 남아있게 되어 요청을 계속 보내도 첫 번째 요청에 대한 응답을 보내는 오동작이 발생하고 있었습니다.
    👉 위의 Worker 멤버 변수를 Request로 옮겨서 구조를 개편하였습니다.

@hhkim0729 @srngch
feat: Implement directory path redirection(#19)
986cd4d 
Additional tasks
- Add 301 Moved Permanently macro
- Move filePath, originalHeader, originalBody member variables from Worker to Request
- Add appendHeader() to Response

Co-authored-by: srngch <srngch.dev@gmail.com>
@hhkim0729 hhkim0729 added bug Something isn't working feature New feature or request labels Oct 16, 2022
@hhkim0729 hhkim0729 requested review from S0YKIM and srngch October 16, 2022 06:30
@hhkim0729 hhkim0729 self-assigned this Oct 16, 2022
S0YKIM
S0YKIM approved these changes Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@S0YKIM S0YKIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

srcs/Worker.cpp Outdated Show resolved Hide resolved
srngch
srngch approved these changes Oct 16, 2022
View reviewed changes
Copy link
Owner

@srngch srngch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오류 발견 정확하게 잘 찾아주셨네요..! LGTM!

@hhkim0729 hhkim0729 merged commit 8e15bce into develop Oct 16, 2022
@hhkim0729 hhkim0729 deleted the feature/19/redirect-directory branch October 16, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srngch srngch srngch approved these changes

@S0YKIM S0YKIM S0YKIM approved these changes

Assignees

@hhkim0729 hhkim0729

Labels
bug Something isn't working feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect if request path is directory
3 participants
@hhkim0729 @S0YKIM @srngch