Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement python-cgi(#32) #37

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

hhkim0729
Copy link
Collaborator

작업 내용

리뷰어에게

  • 클라이언트 요청 메시지를 문자열에서 바이너리로 처리도록 변경하였습니다. 자세한 내용은 커밋 메시지를 참고해주세요.

Additional tasks
- Change original request message type from string to char vector
- Use char vector when writing to Cgi and sending response to client
- Add FileToCharV()

Co-authored-by: srngch <srngch.dev@gmail.com>
@hhkim0729 hhkim0729 added the feature New feature or request label Oct 18, 2022
@hhkim0729 hhkim0729 requested a review from S0YKIM October 18, 2022 07:35
Copy link
Collaborator

@S0YKIM S0YKIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리퀘스트 바디가 바이너리 파일의 내용이라서 std::string 에서 std::vector로 바꾸어 처리하는 것 확인하였습니다. 수고하셨습니다!

@hhkim0729 hhkim0729 merged commit e0501fd into develop Oct 18, 2022
@hhkim0729 hhkim0729 deleted the feature/32/python-cgi branch October 18, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement python-cgi
3 participants