Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRLF issue when response binary file #51

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Fix CRLF issue when response binary file #51

merged 2 commits into from
Oct 20, 2022

Conversation

srngch
Copy link
Owner

@srngch srngch commented Oct 19, 2022

작업 내용

리뷰어에게

  • 오류가 발생하던 이미지도 잘 GET 해옵니다.
  • 추가로 CGI로 body를 보낼 때 char vector의 내용을 반복문 안에서 1바이트씩 write 하던 부분을, casting을 사용하여 라인을 줄였습니다.
  • 용량이 큰 이미지 업로드 테스트를 하면서 Worker 클래스의 BUFFER_LENGTH 사이즈가 업로드 속도에 영향을 준다는 것을 알아냈습니다.

srngch and others added 2 commits October 19, 2022 20:22
@srngch @hhkim0729
fix: Fix CRLF issue when response binary file
269da9e 
Add isCgi flag to Response constructor

Co-authored-by: heehkim <hhkim0729@users.noreply.github.com>
@srngch @hhkim0729
refactor: Use reinterpret cast when converting char vector to char array
3ccadfb 
Co-authored-by: heehkim <hhkim0729@users.noreply.github.com>
@srngch srngch added the bug Something isn't working label Oct 19, 2022
@srngch srngch requested a review from S0YKIM October 19, 2022 11:45
@srngch srngch changed the title Fix/49/response header Fix CRLF issue when response binary file Oct 19, 2022
S0YKIM
S0YKIM approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@S0YKIM S0YKIM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhkim0729 hhkim0729 merged commit 1b42bc8 into develop Oct 20, 2022
@hhkim0729 hhkim0729 deleted the fix/49/response-header branch October 20, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S0YKIM S0YKIM S0YKIM approved these changes

Assignees

@hhkim0729 hhkim0729

@srngch srngch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CRLF issue when response binary file
3 participants
@srngch @S0YKIM @hhkim0729