Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): using globs with $1 output #1088

Merged
merged 1 commit into from
Jun 24, 2020
Merged

fix(cli): using globs with $1 output #1088

merged 1 commit into from
Jun 24, 2020

Conversation

srod
Copy link
Owner

@srod srod commented Jun 24, 2020

related to #1035

npx node-minify --compressor uglify-js --input 'source/**/*.js' --output 'source/$1.min.js' --option '{"warnings": true, "mangle": false}'

@srod srod added the bug label Jun 24, 2020
@srod srod self-assigned this Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1088 into develop will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1088      +/-   ##
===========================================
- Coverage    91.05%   90.63%   -0.43%     
===========================================
  Files           23       23              
  Lines          425      427       +2     
  Branches       105      106       +1     
===========================================
  Hits           387      387              
- Misses          16       17       +1     
- Partials        22       23       +1     
Flag Coverage Δ
#unittests 90.63% <0.00%> (-0.43%) ⬇️
Impacted Files Coverage Δ
packages/cli/src/compress.js 77.77% <0.00%> (-22.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05f55e...a49f415. Read the comment docs.

* temporary workaround to fix $1 in output
eg. --input 'source/**/*.js' --output 'source/$1.min.js'
@srod srod merged commit 2267e24 into develop Jun 24, 2020
@srod srod deleted the fix/cli-glob-1035 branch June 24, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant