Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): remove all from compressors #394

Merged
merged 3 commits into from
Aug 9, 2018
Merged

feat(cli): remove all from compressors #394

merged 3 commits into from
Aug 9, 2018

Conversation

srod
Copy link
Owner

@srod srod commented Aug 9, 2018

The all compressor is:

  • too unstable when using big files
  • when mixed ES5 and ES6, some compressors are crashing
  • passing options for each compressor is messy

The 'all' compressor is:

* too unstable when using big files
* when mixed es5 and es6, some compressors are crashing
* passing options for each compressor is messy
@srod srod self-assigned this Aug 9, 2018
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #394 into develop will increase coverage by 4.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #394      +/-   ##
=========================================
+ Coverage    95.65%   100%   +4.34%     
=========================================
  Files           21     21              
  Lines          437    389      -48     
  Branches        77     70       -7     
=========================================
- Hits           418    389      -29     
+ Misses          18      0      -18     
+ Partials         1      0       -1
Impacted Files Coverage Δ
lib/cli/index.js 100% <100%> (+26.02%) ⬆️
lib/cli/spinner.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f726ff...11983bd. Read the comment docs.

@srod srod merged commit 84b1fd7 into develop Aug 9, 2018
@srod srod deleted the cli-remove-all branch August 9, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant