Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix husky not running unit tests on pre-commit #54

Closed
srodrigo opened this issue Jun 19, 2021 · 0 comments
Closed

fix husky not running unit tests on pre-commit #54

srodrigo opened this issue Jun 19, 2021 · 0 comments
Labels
build Improvements or additions to build tasks

Comments

@srodrigo
Copy link
Owner

There is no test command at the moment because the unit tests script is explicitly suffixed with :unit. Husky is trying to run npm test and failing.

echo 'Error: no test specified'

Husky should run npm run test:unit on pre-commit. Although, since #50, the unit testing strategy will blend with "integrated" (not integration) testing, in which case it might be better to remove the :unit suffix.

@srodrigo srodrigo added the build Improvements or additions to build tasks label Jun 19, 2021
@srodrigo srodrigo changed the title build: fix husky not running unit tests on pre-commit fix husky not running unit tests on pre-commit Jun 19, 2021
@srodrigo srodrigo self-assigned this Jun 19, 2021
@srodrigo srodrigo removed their assignment Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Improvements or additions to build tasks
Projects
None yet
Development

No branches or pull requests

1 participant