Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size: support regex exclusions #131

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Size: support regex exclusions #131

merged 1 commit into from
Dec 28, 2023

Conversation

srvaroa
Copy link
Owner

@srvaroa srvaroa commented Dec 28, 2023

Signed-off-by: Galo Navarro anglorvaroa@gmail.com

@srvaroa
Size: support regex exclusions
960a0a8 
Signed-off-by: Galo Navarro <anglorvaroa@gmail.com>
@srvaroa srvaroa mentioned this pull request Dec 28, 2023
Closed
@akutz
Copy link

akutz commented Dec 28, 2023

Thanks @srvaroa , looks perfect! @dilyar85, thoughts? Since you implemented the labeler, do you think this will work for us to exclude the generated assets?

@dilyar85
Copy link

Thanks @srvaroa , looks perfect! @dilyar85, thoughts? Since you implemented the labeler, do you think this will work for us to exclude the generated assets?

Looks good to me too. Thanks @srvaroa for adding this support :)

@srvaroa srvaroa merged commit 0381dc4 into master Dec 28, 2023
4 checks passed
@srvaroa srvaroa deleted the g.size_exclusions branch December 28, 2023 19:41
@srvaroa
Copy link
Owner Author

srvaroa commented Dec 28, 2023

Thanks @dilyar85 & @akutz, I'll get this released then

@srvaroa
Copy link
Owner Author

srvaroa commented Dec 28, 2023

Done in v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
TestFileMatch TestLabel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srvaroa @akutz @dilyar85