size: composite configuration #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In retrospect, the previous config for size was not very fortunate as it
splits properties that have a semantic relation in two unrelated ones:
- label: M
size-above: 10
size-below: 100
In order to support file exclusions for the size calculation it'd make a
cleaner config schema to have all size properties in a single Size node.
This change introduces a `size` node as a condition configuration that
replaces `size-above` and `size-below`, while respecting backwards
compatibility. Older config files will continue working, but from now on
the way to specify the file condition will be:
- label: M
above: 10
below: 100
Signed-off-by: Galo Navarro <anglorvaroa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In retrospect, the previous config for size was not very fortunate as it splits properties that have a semantic relation in two unrelated ones:
In order to support file exclusions for the size calculation it'd make a cleaner config schema to have all size properties in a single Size node.
This change introduces a
sizenode as a condition configuration that replacessize-aboveandsize-below, while respecting backwards compatibility. Older config files will continue working, but from now on the way to specify the file condition will be: