Add support for different feed types #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christianbundy I would like to help review this. Can you bring the PR up to date with latest master? :) |
|
This invite parsers could be moved into ssb-invite I guess? I think if you're wanting to generalize then don't we need to come up with a new flexible format? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API was assuming that we could translate bytes from public keys to full feed identifiers (with the
ed25519feed type), which isn't possible with other feed types. I've just removed all parts of the API that depend on an implicit feed type, but I'm assuming that we need some of them? I'm looking for input on which exports we can safely remove. The removed exports are: