Skip to content

Fix real reflectance products not showing in product list

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 2, 2024 in 31s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.15 (9.63 -> 9.48)

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication _avhrr_fixtures.py
  • Excess Number of Function Arguments _avhrr_fixtures.py: avhrr_l1b_1_scene

Annotations

Check warning on line 149 in polar2grid/tests/_avhrr_fixtures.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 5 functions with similar structure: avhrr_l1b_1_data_array,avhrr_l1b_2_data_array,avhrr_l1b_3a_data_array,avhrr_l1b_4_data_array and 1 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 237 in polar2grid/tests/_avhrr_fixtures.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Excess Number of Function Arguments

avhrr_l1b_1_scene has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.