Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -add_not_found to scrape any file extension #44

Closed
locvez opened this issue Jul 26, 2015 · 3 comments
Closed

Allow -add_not_found to scrape any file extension #44

locvez opened this issue Jul 26, 2015 · 3 comments

Comments

@locvez
Copy link

locvez commented Jul 26, 2015

Hi,

Firstly, amazing tool, thank you for developing it.

Would it be possible to allow the scraper to scrape any file extension when using the -add_not_found switch? I have 4400 Sinclair Spectrum games and I had to use Bulk Rename Utility to rename all the .z80 files to .zip's and back again once scraped.

I was going to do the same with my BBC Micro games but I noticed some of them have different file extensions.

This would make sense seeing as we know these files are not going to be present in TGDB

@locvez
Copy link
Author

locvez commented Jul 31, 2015

Just an addendum to this - Would it be possible to add a -extensions switch that would allow us to specify custom extensions?

I just find it useful that it can list all discovered roms, even if they don't have metadata / artwork attached as ES removes all text within parenthesis which is handy to keep if you have multiple roms with the same name but it specifies region, or other specifics (for example (48k) or (128k) in the spectrum roms)

So could we then (if this change was implemented) run scraper with the following command :
scraper -add_not_found -extensions .tap .z80 to list all .tap files and all .z80 files in the spectrum rom folder?

Thanks!

@sselph
Copy link
Owner

sselph commented Aug 2, 2015

Hi, I had a similar idea when I first saw the issue I just haven't had much time to work on anything over the past week.

sselph added a commit that referenced this issue Sep 23, 2015
@sselph sselph closed this as completed Sep 23, 2015
@locvez
Copy link
Author

locvez commented Sep 23, 2015

Thanks for this! You rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants