Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scraper fails if rom dir is a symbolic link #66

Closed
MisterTea opened this issue Feb 9, 2016 · 2 comments
Closed

scraper fails if rom dir is a symbolic link #66

MisterTea opened this issue Feb 9, 2016 · 2 comments

Comments

@MisterTea
Copy link

I have all of my rom dirs as symbolic links. filepath.Walk(...) does not follow symbolic links as per https://golang.org/pkg/path/filepath/#Walk

To fix, add this line as the first line of Scrape(...):

xmlOpts.RomDir, _ = filepath.EvalSymlinks(xmlOpts.RomDir)
sselph added a commit that referenced this issue Feb 10, 2016
@sselph
Follow rom_dir symlink. #66
6e0e6aa
@sselph
Copy link
Owner

sselph commented Feb 10, 2016

Thanks. I've made the change.

@MisterTea
Copy link
Author

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MisterTea @sselph