Update package format to julia 1.x #11
Conversation
Manifest.toml
Outdated
| @@ -0,0 +1,94 @@ | |||
| # This file is machine-generated - editing it directly is not advised | |||
There was a problem hiding this comment.
The Manifest.toml file probably shouldn't be included and be added to the .gitignore
Project.toml
Outdated
| version = "0.1.0" | ||
|
|
||
| [deps] | ||
| Compat = "34da2185-b29b-5c13-b0c7-acf172513d20" |
There was a problem hiding this comment.
Most likely Compat was included to support Julia 1.0 when this package supported Julia 0.6. I would try removing this dependency and the using Compat calls and verify it is still needed.
|
|
||
| [compat] | ||
| Compat = "3" | ||
| julia = "1" |
There was a problem hiding this comment.
Double check for conditional code based upon the version like:
Line 17 in cb5550b
There was a problem hiding this comment.
The .travis.yml and appveyor.yml need to be updated to no longer test against Julia 0.6
appveyor.yml
Outdated
| @@ -33,7 +33,7 @@ install: | |||
| build_script: | |||
| # Need to convert from shallow to complete for Pkg.clone to work | |||
| - IF EXIST .git\shallow (git fetch --unshallow) | |||
| - C:\projects\julia\bin\julia -e "versioninfo(); | |||
| - C:\projects\julia\bin\julia -e "using InteractiveUtils; versioninfo(); | |||
| Pkg.clone(pwd(), \"DeepDiffs\"); Pkg.build(\"DeepDiffs\")" | |||
|
|
|||
| test_script: | |||
There was a problem hiding this comment.
Looks like this file hasn't been updated in some time. There is now an easier way: https://github.com/JuliaCI/Appveyor.jl
This should be the updated form I think:
environment:
matrix:
- julia_version: 1
- julia_version: nightly
platform:
- x86 # 32-bit
- x64 # 64-bit
branches:
only:
- master
- /release-.*/
notifications:
- provider: Email
on_build_success: false
on_build_failure: false
on_build_status_changed: false
install:
- ps: iex ((new-object net.webclient).DownloadString("https://raw.githubusercontent.com/JuliaCI/Appveyor.jl/version-1/bin/install.ps1"))
build_script:
- echo "%JL_BUILD_SCRIPT%"
- C:\julia\bin\julia -e "%JL_BUILD_SCRIPT%"
test_script:
- echo "%JL_TEST_SCRIPT%"
- C:\julia\bin\julia -e "%JL_TEST_SCRIPT%"
|
cc: @ssfrr |
Project.toml
Outdated
| keywords = ["diff"] | ||
| license = "MIT" | ||
| desc = "Compute and pretty-print diffs for data structures like arrays and dictionaries" | ||
| version = "0.1.0" |
There was a problem hiding this comment.
| version = "0.1.0" | |
| version = "1.2.0" |
|
This package locks the Edit: the issue got solved in ImageBinarization side |
|
I made a couple minor tweaks. Thanks all for the PR and reviews. I'll get a release out shortly |
|
Thanks for getting this merged. If you want assistance with this package I'd be happy to help out as a maintainer. |
|
Release tagged, just waiting for it to be merged into General: Thanks for the offer of help! I'd be happy and grateful to add you as a maintainer. |
No description provided.