Updates for Julia 0.7 #9
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 197 190 -7
=====================================
- Hits 197 190 -7
Continue to review full report at Codecov.
|
|
Interesting test failures on 0.7. Looks like the color isn't getting applied to the stream? |
This raises the minimum required Julia version to 0.6 release, which is required for any new tags in METADATA, and adds a dependency on Compat to support Julia 0.7. It also fixes all deprecation warnings emitted on Julia 0.7 and adds 0.7 testing to CI.
|
Okay this works locally for me now on 0.7. I've separated the work into 3 logically separate commits. |
|
UGH now it doesn't work on 0.6. |
|
Ah, the difference is in JuliaLang/julia#25067. |
ararslan
force-pushed
the
aa/0.7
branch
2 times, most recently
from
cff845f
to
c709286
Compare
In Julia 0.7, whether an IO object supports color is a property of its context; Base.have_color refers only to whether Julia was launched with --color=yes. In 0.6, controlling color requires manipulating that global flag. Thus we'll hack around the difference with version checking.
test/runtests.jl
Outdated
| @testset DottedTestSet "DeepDiff Tests" begin | ||
| @includetests ARGS | ||
| # Capture the original state of the global flag | ||
| orig_color = Base.have_color |
There was a problem hiding this comment.
Should this be wrapped in a version check? I think this variable is only used if we're running a version before color was moved into the IOContext, so it seems like this could be also. That way if Base.have_color disappears the tests will still run.
There was a problem hiding this comment.
Good call. I've pushed a commit that wraps it in isdefined.
|
Merged and released as 1.1.0. Thanks! |
Summary of changes: