Fix SocketAsyncEventArgsAwaitable calling continuation multiple times (…

…#918) * Fix SocketAsyncEventArgsAwaitable calling continuation multiple times * Use Interlocked.Exchange --------- Co-authored-by: Rob Hague <rob.hague00@gmail.com>
sshnet · Apr 27, 2024 · 59840ec · 59840ec
1 parent 4e1e243
commit 59840ec
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/Renci.SshNet/Abstractions/SocketExtensions.cs b/src/Renci.SshNet/Abstractions/SocketExtensions.cs
@@ -33,11 +33,10 @@ public AwaitableSocketAsyncEventArgs ExecuteAsync(Func<SocketAsyncEventArgs, boo
                 return this;
             }
 
-            public void SetCompleted()
+            private void SetCompleted()
             {
                 IsCompleted = true;
-
-                var continuation = _continuationAction ?? Interlocked.CompareExchange(ref _continuationAction, SENTINEL, comparand: null);
+                var continuation = Interlocked.Exchange(ref _continuationAction, SENTINEL);
                 if (continuation is not null)
                 {
                     continuation();