Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail with a friendlier error message when response has not been set #1245

Merged

Conversation

Rob-Hague
Copy link
Collaborator

...in keyboard-interactive mode.

Closes #1237
Closes #382

@WojciechNagorski
Copy link
Collaborator

Is there a possibility to add a test for that?

@Rob-Hague
Copy link
Collaborator Author

Rob-Hague commented Nov 18, 2023

I wrote a unit test, but there were several issues with using a mocked ISession relating to visibility.

I felt that an integration test was a bit heavy for this, but I'll look at adding one anyway.

@scott-xu
Copy link
Collaborator

scott-xu commented Nov 27, 2023

What about separate the two

– Response null check

  • IReadOnlyList and order removal

@Rob-Hague
Copy link
Collaborator Author

I'll just add the order by back. There is no need to waste time on this

@Rob-Hague Rob-Hague force-pushed the keyboardinteractivenullresponse branch from 1edc34f to dff8fe4 Compare November 27, 2023 18:01
@WojciechNagorski WojciechNagorski merged commit a027c76 into sshnet:develop Dec 2, 2023
1 check passed
@Rob-Hague Rob-Hague deleted the keyboardinteractivenullresponse branch December 2, 2023 15:33
@WojciechNagorski WojciechNagorski added this to the 2023.0.1 milestone Dec 20, 2023
@WojciechNagorski
Copy link
Collaborator

The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants