Disable some impactful analyzers #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Hague
requested review from
drieseng and
WojciechNagorski
as code owners
|
LGTM! I think it's good compromise. |
Is that also the explanation for the Meziantou numbers? As far as I can tell, you didn't disable any of it rules. |
drieseng
requested changes
Nov 28, 2023
Yes I believe so, I don't have a better explanation (sorry, somehow I edited your comment to this comment...) |
drieseng
approved these changes
Dec 2, 2023
Closed
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I promise to stop whining about analyzers if this is merged.
Before:
After:
Done with a clean build each time (
git clean -xdf). The individual numbers are quite variable, but it is around 60% build time reduction (still much longer than it used to be).