Test integration tests #1250
Merged
Test integration tests #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe take this change to limit parallel appveyor runs: |
|
@drieseng I need admin permissions to Appveyor. I've run tests locally in this way and generated a test coverage |
|
|
Rob-Hague
reviewed
Nov 23, 2023
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
Rob-Hague
reviewed
Nov 23, 2023
Rob-Hague
reviewed
Nov 23, 2023
Co-authored-by: Rob Hague <rob.hague00@gmail.com>
Rob-Hague
reviewed
Nov 23, 2023
Rob-Hague
reviewed
Nov 29, 2023
There was a problem hiding this comment.
You can run dotnet new gitignore to get a better .gitignore file
Rob-Hague
reviewed
Nov 29, 2023
appveyor.yml
Outdated
| @@ -21,16 +21,16 @@ for: | |||
|
|
|||
| build_script: | |||
| - echo build | |||
| #- dotnet build Renci.SshNet.sln -c Debug -f net7.0 | |||
| - dotnet build Renci.SshNet.sln -c Debug -f net7.0 | |||
|
|
|||
| test_script: | |||
| - sh: echo "Run unit tests" | |||
| # - sudo tcpdump -i docker0 -w artifacts/tcpdump.pcap -U & | |||
There was a problem hiding this comment.
Feel free to delete all the commented-out stuff
|
@Rob-Hague @drieseng Is ready to review. It works: The Zip result:
SummarySummary
CoverageRenci.SshNet - 64%
|
Rob-Hague
approved these changes
Nov 29, 2023
...nci.SshNet.Tests/Classes/Connection/DirectConnectorTest_Connect_TimeoutConnectingToServer.cs
Outdated
Show resolved
Hide resolved
…_Connect_TimeoutConnectingToServer.cs Co-authored-by: Rob Hague <rob.hague00@gmail.com>
|
| Could we do this on appveyor and publish the html report in the artifacts? Not necessarily in this PR Yes. But artifacts come from different jobs so we have to create a next one at the end that will collect artifacts and calculate reports. This is for next PR. |
…echNagorski/SSH.NET into integration-tests-appveyor
|
How about upload the coverage report to codecov? Then a code coverage badge can be added to the repo's readme page. The badge is a hyper link to codecov website with coverage info and can drill down to details. |
|
@Rob-Hague can you take a look? It's finished and stable. |
Rob-Hague
approved these changes
Nov 30, 2023
I drafted a PR for codecov integration: #1257 |
Closed
|
The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.