Fixed dequeuing of incoming queue #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscarle
force-pushed
the
develop
branch
2 times, most recently
from
1f4cadc to
dec5149
Compare
jscarle
changed the title
|
@WojciechNagorski Following @Rob-Hague 's observation in #1207, there is indeed an issue where the incoming queue may not dequeue at the same rate as the expect queue if the data that has not been processed exceeds the size of the expect buffer. An improbable case, but nonetheless, this PR fixes that. |
|
Additionally, I made sure that the full incoming queue is returned when Expect matches and not just the expected queue. |
|
@WojciechNagorski @Rob-Hague This is ready to be merged. |
WojciechNagorski
approved these changes
Feb 13, 2024
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the dequeueing of the _incoming queue following #1207 and added the related test to protect against future regressions.