Tweak AsyncSocketListener in tests #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CI runs have been crashing lately from within AsyncSocketListener. This moves a bit of disconnection & exception handling around. It probably won't fix the underlying tests which would have otherwise failed, but it might stop the process from outright crashing. Also reference the same code for the integration tests.
Rob-Hague
commented
Apr 25, 2024
| @@ -322,23 +284,36 @@ void ConnectionDisconnected() | |||
| } | |||
| catch (ObjectDisposedException) | |||
| { | |||
| // TODO On .NET 7, sometimes we get ObjectDisposedException when _started but only on appveyor, locally it works | |||
| ConnectionDisconnected(); | |||
There was a problem hiding this comment.
This was the main problem. If we have received ObjectDisposedException, we don't want to call Shutdown on the socket because we will get another ObjectDisposedException, and that will crash the process.
|
This is a very difficult piece of code. Sockets will behave differently on Linux and Windows and in the .NET Framework and modern .NET. In addition, different tests use the |
|
Yeah, I figured this at least removes one way of crashing. There might still be more |
KodakDave00119
approved these changes
May 2, 2024
| @@ -8,6 +8,10 @@ | |||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Compile Include="$(ProjectDir)../Renci.SshNet.Tests/Common/AsyncSocketListener.cs" /> | |||
WojciechNagorski
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CI runs have been crashing lately from within AsyncSocketListener. This moves a bit of disconnection & exception handling around. It probably won't fix the underlying tests which would have otherwise failed, but it might stop the process from outright crashing.
Also reference the same code for the integration tests.