fix flaky SFTP file time tests #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These asserts currently assume that DateTime.Now and the creation timestamp on the server happen within the same second. Note that I didn't change the asserts below where an explicit timestamp is set. From my understanding, these should not be affected. example: https://ci.appveyor.com/project/drieseng/ssh-net/builds/49850731/job/u6lk0cyipbxkp4jd
mus65
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
|
Thanks, I'm pretty sure I just deleted these asserts in some similar tests but maybe I missed some. I'm out for the next week or so so may not come back until then |
|
Yeah, let's just delete them. The real asserts are a few lines lower. |
|
I removed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These asserts currently assume that DateTime.Now and the creation timestamp on the server happen within the same second.
Note that I didn't change the asserts below where an explicit timestamp is set. From my understanding, these should not be affected.
example: https://ci.appveyor.com/project/drieseng/ssh-net/builds/49850731/job/u6lk0cyipbxkp4jd