Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some #ifdefs with System.Memory #1434

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Remove some #ifdefs with System.Memory #1434

merged 1 commit into from
Jul 5, 2024

Conversation

Rob-Hague
Copy link
Collaborator

@Rob-Hague Rob-Hague commented Jul 3, 2024 •
edited
Loading

No description provided.

@Rob-Hague
Copy link
Collaborator Author

The .NET Framework integration tests look good locally (I wish we could run them in CI)

@Rob-Hague Rob-Hague marked this pull request as ready for review July 5, 2024 06:54
WojciechNagorski
WojciechNagorski approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WojciechNagorski WojciechNagorski merged commit ffd43da into sshnet:develop Jul 5, 2024
1 check passed
@Rob-Hague
Copy link
Collaborator Author

Thanks

@Rob-Hague Rob-Hague deleted the span branch July 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WojciechNagorski WojciechNagorski WojciechNagorski approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rob-Hague @WojciechNagorski