Skip to content

Commit

Permalink
Cleanup comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ssjunnebo committed Oct 3, 2024
1 parent 8a28e89 commit 1e168a2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion taca/analysis/analysis_element.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def _process(run):
else:
data_dirs = CONFIG.get("element_analysis").get(
"data_dirs"
) # TODO: add to config
)
for data_dir in data_dirs:
# Run folder looks like DATE_*_*, the last section is the FC side (A/B) and name
runs = glob.glob(os.path.join(data_dir, "[1-9]*_*_*"))
Expand Down
14 changes: 7 additions & 7 deletions taca/element/Element_Runs.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def __init__(self, run_dir, configuration):
.get("Element", {})
.get(self.sequencer_type, {})
.get("transfer_log")
) # TODO: add to taca.yaml
)
self.rsync_exit_file = os.path.join(self.run_dir, ".rsync_exit_status")

# Instrument generated files
Expand Down Expand Up @@ -340,7 +340,7 @@ def get_lims_step_id(self) -> str | None:
the ID of the LIMS step can be extracted from it.
"""

# TODO test me
# TODO: test me

assert self.manifest_exists(), "Run manifest not found"
with open(self.run_manifest_file_from_instrument) as csv_file:
Expand All @@ -357,7 +357,7 @@ def find_manifest_zip(self):
self.CONFIG.get("element_analysis")
.get("Element", {})
.get(self.sequencer_type, {})
.get("manifest_zip_location"), # TODO: add to taca.yaml
.get("manifest_zip_location"),
str(self.year),
)

Expand Down Expand Up @@ -575,15 +575,15 @@ def make_demux_manifests(

def generate_demux_command(self, run_manifest, demux_dir):
command = (
f"{self.CONFIG.get('element_analysis').get('bases2fastq')}" # TODO: add path to bases2fastq executable to config
f"{self.CONFIG.get('element_analysis').get('bases2fastq')}"
+ f" {self.run_dir}"
+ f" {demux_dir}"
+ " -p 8"
+ " --num-unassigned 500"
+ f" -r {run_manifest}"
+ " --legacy-fastq"
+ " --force-index-orientation"
) # TODO: any other options?
)
with open(os.path.join(self.run_dir, ".bases2fastq_command")) as command_file:
command_file.write(command)
return command
Expand Down Expand Up @@ -1091,7 +1091,7 @@ def sync_metadata(self):
]
metadata_archive = self.CONFIG.get("element_analysis").get(
"metadata_location"
) # TODO: add to taca.yaml
)
dest = os.path.join(metadata_archive, self.NGI_run_id)
os.makedirs(dest)
for f in files_to_copy:
Expand All @@ -1104,7 +1104,7 @@ def make_transfer_indicator(self):
def transfer(self):
transfer_details = self.CONFIG.get("element_analysis").get(
"transfer_details"
) # TODO: Add section to taca.yaml
)
command = (
"rsync"
+ " -rLav"
Expand Down

0 comments on commit 1e168a2

Please sign in to comment.