Troubleshooting and fixing manifest handling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssjunnebo
approved these changes
Oct 7, 2024
| @@ -379,44 +374,38 @@ def find_manifest_zip(self): | |||
| logger.warning( | |||
| f"No manifest found for run '{self.run_dir}' with pattern '{glob_pattern}'." | |||
| ) | |||
| return False # TODO: determine whether to raise an error here instead | |||
| return None | |||
| elif len(glob_results) > 1: | |||
| logger.warning( | |||
| f"Multiple manifests found for run '{self.run_dir}' with pattern '{glob_pattern}', using latest one." | |||
| ) | |||
| glob_results.sort() | |||
There was a problem hiding this comment.
I guess this works as long as no-one renames the manifest files, which we do for illumina during redemux. Fine for now but we need to think about it later.
There was a problem hiding this comment.
If redemux is done manually, how about overriding the demux file path as a CLI parameter?
There was a problem hiding this comment.
Yeah I think that would make sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.