Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holding undo should not undo past 0 steps #815

Open
sspenst opened this issue Jan 18, 2023 · 0 comments · Fixed by #819
Open

Holding undo should not undo past 0 steps #815

sspenst opened this issue Jan 18, 2023 · 0 comments · Fixed by #819
Labels
enhancement New feature or request
Milestone
2303

Comments

@sspenst
Copy link
Owner

sspenst commented Jan 18, 2023

Issue: when holding undo to get back to the beginning (instead of using restart), sometimes you will undo back to the previous attempt

Solution: require a new undo keydown on 0 steps to go back to the previous attempt (don't allow holding undo from 10 steps for example)
k2xl added a commit that referenced this issue Jan 20, 2023
@k2xl
fix #815. hacky but seems to work
eab4d7a
@k2xl k2xl linked a pull request Jan 20, 2023 that will close this issue
fix #815. hacky but seems to work #819
Merged
@k2xl k2xl closed this as completed in #819 Jan 21, 2023
k2xl added a commit that referenced this issue Jan 21, 2023
@k2xl
fix #815. hacky but seems to work (#819)
299b77a
@sspenst sspenst reopened this Jan 21, 2023
@sspenst sspenst added the enhancement New feature or request label Jan 24, 2023
@sspenst sspenst added this to the 1 milestone Feb 10, 2023
@sspenst sspenst modified the milestones: 2302, 2303 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2303
Development

Successfully merging a pull request may close this issue.

fix #815. hacky but seems to work sspenst/thinky.gg
1 participant
@sspenst