Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output should adapt to actual width of the terminal #13

Merged
merged 3 commits into from
Feb 9, 2019
Merged

output should adapt to actual width of the terminal #13

merged 3 commits into from
Feb 9, 2019

Conversation

boris-brtan
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Standards and tests pass? yes
Fixes issues during the tests of implementation in our monorepo we have 175 yaml files checked and if we do not have opened terminal window with so many columns it will wrap into almost infinity
License MIT

Before

image
image

After

image
image

@boris-brtan boris-brtan mentioned this pull request Jan 30, 2019
Merged
@boris-brtan
Copy link
Contributor Author

boris-brtan commented Jan 31, 2019 •
edited
Loading

all strange standards are OK::::: squash & merge it now @sspooky13

@sspooky13
Copy link
Owner

Hello @boris-brtan,
thanks for your PL. You need little bit patience, I don't have time every day, mostly in weekend I do my personal things.

Why "strange standards"? It's your standards. If you are discontented with them, you can suggest improvements.
BTW: if you know better standards repository, I will glad for suggestions, but you remember I support also 5.6 PHP version.

@sspooky13 sspooky13 self-requested a review February 3, 2019 14:42
sspooky13
sspooky13 requested changes Feb 3, 2019
View reviewed changes
Copy link
Owner

@sspooky13 sspooky13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 points in your code. I don't report every trifle, I fix them myself.
After you answer/fix those points I accept your PL 🙂

src/ProcessOutput.php Show resolved Hide resolved
src/ProcessOutput.php Outdated Show resolved Hide resolved
boris-brtan
boris-brtan commented Feb 9, 2019
View reviewed changes
src/ProcessOutput.php Outdated Show resolved Hide resolved
@sspooky13 sspooky13 merged commit e117979 into sspooky13:master Feb 9, 2019
sspooky13 added a commit that referenced this pull request Feb 9, 2019
@sspooky13
Output result: output now adapts to the actual window width of the te…
cc530d8 
…rminal

#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspooky13 sspooky13 sspooky13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boris-brtan @sspooky13