Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested hierarchy in yaml #27

Merged
merged 7 commits into from
Jul 26, 2019
Merged

Fix nested hierarchy in yaml #27

merged 7 commits into from
Jul 26, 2019

Commits on Jul 25, 2019

  1. add failing unit test for indentation edge-case 

    - see shopsys/shopsys#539 (comment)
    @PetrHeinz
    PetrHeinz committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    48149b2 View commit details
    Browse the repository at this point in the history

  2. simplify YamlIndentDataFactory::getCorrectIndents()

    @PetrHeinz
    PetrHeinz committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    587c593 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. fix nested hierarchy in array

    @PetrHeinz @sspooky13
    PetrHeinz authored and sspooky13 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    11e3139 View commit details
    Browse the repository at this point in the history

  2. YamlIndentCheckerTest: added assertion message for clarity

    @PetrHeinz @sspooky13
    PetrHeinz authored and sspooky13 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    f14a132 View commit details
    Browse the repository at this point in the history

  3. YamlService: added methods for counting indentation 

    - all occurrences replaced by the method calls
- method call was inlined if the variable was used only once
    @PetrHeinz @sspooky13
    PetrHeinz authored and sspooky13 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    e09704b View commit details
    Browse the repository at this point in the history

  4. YamlIndentDataFactory: fix nested array on any level (instead of only… 

    … root)
    @PetrHeinz @sspooky13
    PetrHeinz authored and sspooky13 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    c032175 View commit details
    Browse the repository at this point in the history

  5. update changelog

    @sspooky13
    sspooky13 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    d795077 View commit details
    Browse the repository at this point in the history