Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide progress bar using --no-progress-bar #79

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

techi602
Copy link
Contributor

@techi602 techi602 commented Feb 2, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Fixes issues
License MIT

It is common practise for CLI tools to have option to disable progress bar since it makes mess in CI logs. Such as
image

I have added option --no-progress-bar similar to https://github.com/easy-coding-standard/easy-coding-standard/

@sspooky13
Copy link
Owner

Thanks for your PR 👌

Copy link

sonarcloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sspooky13 sspooky13 merged commit 3efd27c into sspooky13:master Feb 4, 2024
126 checks passed
@cafferata
Copy link
Contributor

@sspooky13, what are the expectations for a new tag (release)? ☺️

@sspooky13
Copy link
Owner

Hi @cafferata,
I want to finish #49 but I don't have any time 😐 But if you need I can release new version today or tomorrow on actual master.

@cafferata
Copy link
Contributor

@sspooky13 there is no 'need'. It's more of a nice to have. After seeing this GitHub pull request, I prepared massive GitLab merge request that included this new option --no-progress-bar within our GitLab CI set-up.

These GitLab merge requests are now waiting for the release of the new option because the GitLab CI jobs will no longer work with the unreleased option --no-progress-bar:

./vendor/bin/yaml-standards --no-progress-bar
The "--no-progress-bar" option does not exist.

So I can't bring these GitLab merge requests to master without breaking the GitLab CI. ☺️

@sspooky13
Copy link
Owner

sspooky13 commented Mar 7, 2024

@cafferata I understand (I hope 😅), anyway, new version was released yesterday, so you can use this option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants