fix code review

ssripadham · Feb 3, 2020 · 79d7fb8 · 79d7fb8
1 parent 40587b7
commit 79d7fb8
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 68 deletions.
diff --git a/...nager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesCreate.json b/...nager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesCreate.json
@@ -5,7 +5,7 @@
     "resourceGroupName": "my-resource-group",
     "scopeName": "my-privatelinkscope",
     "AzureMonitorPrivateLinkScopePayload": {
-      "location": "South Central US",
+      "location": "Global",
       "properties": {}
     }
   },
@@ -15,7 +15,7 @@
         "id": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4919/resourceGroups/my-resource-group/providers/microsoft.insights/privateLinkScopes/my-privatelinkscope",
         "name": "my-privatelinkscope",
         "type": "Microsoft.Insights/privateLinkScopes",
-        "location": "South Central US",
+        "location": "Global",
         "tags": {},
         "properties": {
           "scopeId": "d1c8fc00-2b68-441e-8f9b-ded8748dc635",

diff --git a/...-manager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesGet.json b/...-manager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesGet.json
@@ -11,7 +11,7 @@
         "id": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4919/resourceGroups/my-resource-group/providers/microsoft.insights/privateLinkScopes/my-privatelinkscope",
         "name": "my-privatelinkscope",
         "type": "Microsoft.Insights/privateLinkScopes",
-        "location": "southcentralus",
+        "location": "Global",
         "tags": {},
         "properties": {
           "scopeId": "d1c8fc00-2b68-441e-8f9b-ded8748dc635",

diff --git a/...manager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesList.json b/...manager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesList.json
@@ -11,7 +11,7 @@
             "id": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4919/resourceGroups/my-resource-group/providers/microsoft.insights/privateLinkScopes/my-privatelinkscope",
             "name": "my-privatelinkscope",
             "type": "Microsoft.Insights/privateLinkScopes",
-            "location": "South Central US",
+            "location": "Global",
             "tags": {},
             "properties": {
               "scopeId": "d1c8fc00-2b68-441e-8f9b-ded8748dc6aa",
@@ -24,7 +24,7 @@
             "id": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4919/resourceGroups/my-other-resource-group/providers/microsoft.insights/privateLinkScopes/my-other-privatelinkscope",
             "name": "my-other-privatelinkscope",
             "type": "Microsoft.Insights/privateLinkScopes",
-            "location": "South Central US",
+            "location": "Global",
             "tags": {},
             "properties": {
               "scopeId": "aac8fc00-2b68-441e-8f9b-ded8748dc635",

diff --git a/...ft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesListByResourceGroup.json b/...ft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesListByResourceGroup.json
@@ -12,7 +12,7 @@
             "id": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4919/resourceGroups/my-resource-group/providers/microsoft.insights/privateLinkScopes/my-privatelinkscope",
             "name": "my-privatelinkscope",
             "type": "Microsoft.Insights/privateLinkScopes",
-            "location": "South Central US",
+            "location": "Global",
             "tags": {},
             "properties": {
               "scopeId": "d1c8fc00-2b68-441e-8f9b-ded8748dc6aa",
@@ -25,7 +25,7 @@
             "id": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4919/resourceGroups/my-resource-group/providers/microsoft.insights/privateLinkScopes/my-other-privatelinkscope",
             "name": "my-other-privatelinkscope",
             "type": "Microsoft.Insights/privateLinkScopes",
-            "location": "South Central US",
+            "location": "Global",
             "tags": {},
             "properties": {
               "scopeId": "aac8fc00-2b68-441e-8f9b-ded8748dc635",

diff --git a/...nager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesUpdate.json b/...nager/Microsoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesUpdate.json
@@ -5,7 +5,7 @@
     "resourceGroupName": "my-resource-group",
     "scopeName": "my-privatelinkscope",
     "AzureMonitorPrivateLinkScopePayload": {
-      "location": "South Central US",
+      "location": "Global",
       "tags": {
         "Tag1": "Value1"
       },
@@ -18,7 +18,7 @@
         "id": "/subscriptions/86dc51d3-92ed-4d7e-947a-775ea79b4919/resourceGroups/my-resource-group/providers/microsoft.insights/privateLinkScopes/my-privatelinkscope",
         "name": "my-privatelinkscope",
         "type": "Microsoft.Insights/privateLinkScopes",
-        "location": "South Central US",
+        "location": "Global",
         "tags": {
           "Tag1": "Value1"
         },

diff --git a/...crosoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesUpdateTagsOnly.json b/...crosoft.Insights/preview/2019-10-17-preview/examples/PrivateLinkScopesUpdateTagsOnly.json
@@ -17,7 +17,7 @@
         "id": "/subscriptions/subid/resourceGroups/my-resource-group/providers/microsoft.insights/privateLinkScopes/my-privatelinkscope",
         "name": "my-privatelinkscope",
         "type": "Microsoft.Insights/privateLinkScopes",
-        "location": "South Central US",
+        "location": "Global",
         "tags": {
           "Tag1": "Value1",
           "Tag2": "Value2"

diff --git a/...resource-manager/Microsoft.Insights/preview/2019-10-17-preview/privateLinkScopes_API.json b/...resource-manager/Microsoft.Insights/preview/2019-10-17-preview/privateLinkScopes_API.json
@@ -578,44 +578,6 @@
         }
       }
     },
-    "PrivateLinkScopesResource": {
-      "properties": {
-        "id": {
-          "type": "string",
-          "readOnly": true,
-          "description": "Azure resource Id"
-        },
-        "name": {
-          "type": "string",
-          "description": "Azure resource name",
-          "readOnly": true
-        },
-        "type": {
-          "type": "string",
-          "readOnly": true,
-          "description": "Azure resource type"
-        },
-        "location": {
-          "type": "string",
-          "description": "Resource location",
-          "x-ms-mutability": [
-            "create",
-            "read"
-          ]
-        },
-        "tags": {
-          "additionalProperties": {
-            "type": "string"
-          },
-          "description": "Resource tags"
-        }
-      },
-      "required": [
-        "location"
-      ],
-      "x-ms-azure-resource": true,
-      "description": "An azure resource object"
-    },
     "TagsResource": {
       "properties": {
         "tags": {
@@ -637,7 +599,7 @@
       },
       "allOf": [
         {
-          "$ref": "#/definitions/PrivateLinkScopesResource"
+          "$ref": "../../common/v1/definitions.json#/definitions/TrackedResource"
         }
       ],
       "required": [
@@ -648,23 +610,6 @@
     "AzureMonitorPrivateLinkScopeProperties": {
       "description": "Properties that define a Azure Monitor PrivateLinkScope resource.",
       "properties": {
-        "scopeId": {
-          "type": "string",
-          "description": "The unique ID of your application. This field cannot be changed.",
-          "readOnly": true
-        },
-        "timeCreated": {
-          "type": "string",
-          "readOnly": true,
-          "description": "Creation Date for the Azure Monitor PrivateLinkScope, in ISO 8601 format.",
-          "format": "date-time"
-        },
-        "timeModified": {
-          "type": "string",
-          "readOnly": true,
-          "description": "Last modified date of the Azure Monitor PrivateLinkScope, in ISO 8601 format.",
-          "format": "date-time"
-        },
         "provisioningState": {
           "type": "string",
           "description": "Current state of this PrivateLinkScope: whether or not is has been provisioned within the resource group it is defined. Users cannot change this value but are able to read from it. Values will include Provisioning ,Succeeded, Canceled and Failed.",
@@ -772,8 +717,7 @@
           "description": "Resource id of the private endpoint.",
           "type": "string"
         }
-      },
-      "x-ms-azure-resource": true
+      }
     },
     "PrivateLinkServiceConnectionStateProperty": {
       "description": "State of the private endpoint connection.",