feat: Adding Basic Auth to access Helm repo #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstarcher
reviewed
Feb 1, 2022
sstarcher
reviewed
Feb 1, 2022
sstarcher
reviewed
Feb 1, 2022
|
This will also be a breaking change for people due to the URL format changing. Would it make sense for us to strip off index.yaml if the user specifies it to be backward compatible? |
Done, added a trimSuffix to remove the /index.yaml part. Looking forward for your feedback. |
sstarcher
reviewed
Feb 3, 2022
sstarcher
reviewed
Feb 3, 2022
dirien
force-pushed
the
auth
branch
2 times, most recently
from
369b253
to
714095f
Compare
|
Can you resolve the conflict |
|
@sstarcher done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #41
This PR introduce the basic auth of private helm registries via the helm sdk. Now, you dont need to transform the index.yaml anymore. The helm sdk takes care to return the latest version.