This repository has been archived by the owner on Apr 29, 2021. It is now read-only.
This commit corrects the problem of incorrect TAP format for skipped tests. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format for skipped tests.
|
Is there anyone who can merge this PR? It is correct, and it fixes the stated issue. |
|
@harschware Your patch works. Haven't really looked at the implementation or the tests though. |
1 task
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue #141 , TAP format is incorrect. This PR corrects the problem, and adds a test case that uses the "skip reason" feature of BATS to ensure the correct output is produced.