Testing: Use class methods for downloads #2431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for expensive operations such as downloads or initializing large objects.
jmlapre
added
the
AT: WIP
jmlapre
changed the title
gvoskuilen
reviewed
Dec 19, 2024
|
|
||
| def setUp(self): | ||
| super(type(self), self).setUp() | ||
| if self.__class__.download_file is None: | ||
| self.skipTest("File not downloaded!") |
There was a problem hiding this comment.
What happens when running the tests concurrently? setUpClass is skipped so these tests will always be skipped?
There was a problem hiding this comment.
Yes, that's the proposed behavior. The fix is more involved than simply calling setUpClass() where initializeClass() is called...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be using the standard
setUpClass()class method for time consuming unit test operations such as downloading a file. This currently works properly with thesst-unittestframework in serial mode but does not work in concurrent mode. Currently it skips the tests ifsetUpClass()hasn't been executed. I'm marking this as WIP to prevent an automerge from occurring before it gets reviewed.