Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit validation #43

Merged
merged 20 commits into from
Mar 10, 2024
Merged

Deposit validation #43

merged 20 commits into from
Mar 10, 2024

Conversation

pavelkrolevets
Copy link
Contributor

@pavelkrolevets pavelkrolevets commented Feb 19, 2024

We need to double check deposit_file.json before it gets submitted to mainnet.

  • added partial launchpad checks as we want to validate BLS signature using JS library before submitting the deposit.
  • copy launchpad validation logic to golang

To run:

  1. Build docker image
make docker-build-deposit-verify
  1. Run docker container with 2 params: DEPOSIT_FILE_PATH=[path to deposit_file.json] and NETWORK_ENV_PATH=[path to network env (e.g. .env.holesky)]
make DEPOSIT_FILE_PATH=/home/pk/go/src/github.com/bloxapp/ssv-dkg/examples/deposit_data.json NETWORK_ENV_PATH=/home/pk/go/src/github.com/bloxapp/ssv-dkg/utils/deposit_verify/.env.holesky docker-deposit-verify

@pavelkrolevets pavelkrolevets changed the title Deposit validate Deposit validation Feb 28, 2024
@MatusKysel MatusKysel marked this pull request as ready for review February 28, 2024 11:22
pavelkrolevets and others added 4 commits March 7, 2024 17:22
Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com>
Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com>
@pavelkrolevets pavelkrolevets added the enhancement New feature or request label Mar 8, 2024
@moshe-blox moshe-blox changed the base branch from main to unstable March 10, 2024 15:42
@moshe-blox moshe-blox merged commit 5dc6354 into unstable Mar 10, 2024
1 check passed
@moshe-blox moshe-blox deleted the deposit_validate branch March 10, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants