Ensure special keys are not in content when loaded #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loader pop'd keys like collection off the item, then dehydrated the item to be used as the 'content'. With collection removed prior to dehydration, it was flagged with the "do-not-merge" marker because the key is on the base_item. Instead, ensure that id, collection, and geometry are not in content as they are stored on the table row and shouldn't participate in hydration. Additionally, bbox was previously a derived value at search runtime but was recently changed to a returned value if it existed on the item. However, during loading, the bbox was dropped so would never exist on the persisted item.
lossyrob
reviewed
May 13, 2022
lossyrob
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loader pop'd keys like
collectionoff the item, then dehydrated theitem to be used as the 'content'. With
collectionremoved prior todehydration, it was flagged with the "do-not-merge" marker because the
key is on the base_item. Instead, ensure that id, collection, and
geometry are not in
contentas they are stored on the table row andshouldn't participate in hydration.
Additionally, bbox was previously a derived value at search runtime but
was recently changed to a returned value if it existed on the item.
However, during loading, the bbox was dropped so would never exist on
the persisted item.