Fix loading issues with dehydrated load #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves away from using
csv
to read the dehydrated, direct table output and fixes an issue with loading quoted values.The CSV reader has a field size limit that can be reached with large items, producing:
This can be worked around by setting a larger value through a method like:
However, the fact we use the CSV reader unquoted tab-delimited also seems sus - what happens if an Item description has a tab in it? This PR contains changes that moves away from using the csv reader and ensures this wouldn't be an issue.
Also, loading a dumped item table from the PC found another issue - items with escape quoted values (e.g. WKT2) were causing errors in loading. This replaces the troublesome quote character on reading in the table data.