-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust Hydration #201
Rust Hydration #201
Conversation
…ime, and end_datetime generated fields to collections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with the postgres internals of pgstac, but the Rust code and Rust CI changes look good
Main blocker is me being out of the office. I'm hoping to get everything merged on Monday. If i hit any road blocks I'll split things up |
@kylebarron @gadomski I updated to use pyo3 rather than serde using sample code from @gadomski. As we discussed last week, my main goal here is to get the infrastructure into place for incorporating rust with hopefully a bit of a win on hydration performance, but more with an eye towards moving much of the json parsing as well as things like injecting links into rust in the future. |
This fixes a permissions error when running the test scripts as non-root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitner I made a couple of touchups to the Rust code and the pypgstac Dockerfile. LGTM for a first-pass, .
Thanks @gadomski and @kylebarron for all the review / code! I'm going to merge this now, but not going to cut a release until I do some heavy benchmarking with PC. |
pydantic
requirement to~=2.0