Update rust re-hydration code to pyo3 0.21 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitner
approved these changes
Apr 29, 2024
|
Hey @kylebarron can you fix the merge issues that this has from your other PR? |
bitner
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a bunch of pyo3 changes from 0.20 to 0.21, namely the introduction of the
Boundsmart pointer. I've not fully grokked my head around it, but this compiles without any of the deprecated "gil-refs" code.As well as keeping up to date with the latest dependency versions, this has the potential to decently improve performance for code that interacts heavily with the Python interpreter, such as the rehydration code.