We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
headers
In Client.open, the headers argument is ignored if at stac_io is provided:
Client.open
stac_io
pystac-client/pystac_client/client.py
Lines 194 to 199 in 37b9b59
This can lead to surprising behavior when, e.g., using basic authentication with a custom StacIO:
from pystac_client import Client from pystac_client.stac_api_io import StacApiIO headers = {"Authorization": "Basic not-a-real-token"} stac_io = StacApiIO() # needs to be StacApiIO(headers=headers) stac_io.session.verify = False client = Client.open("https://pystac-client.test", headers=headers, stac_io=stac_io) # headers are silently ignored
This should be fixed to either:
Option 1 feels right, but let's see which implements better.
The text was updated successfully, but these errors were encountered:
gadomski
Successfully merging a pull request may close this issue.
In
Client.open
, theheaders
argument is ignored if atstac_io
is provided:pystac-client/pystac_client/client.py
Lines 194 to 199 in 37b9b59
This can lead to surprising behavior when, e.g., using basic authentication with a custom StacIO:
This should be fixed to either:
headers
onto thestac_io
, orheaders
andstac_io
are providedOption 1 feels right, but let's see which implements better.
The text was updated successfully, but these errors were encountered: