Update stac_api_io w/ headers, etc #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geosynopsis
approved these changes
Mar 3, 2023
gadomski
force-pushed
the
issues/430-headers-custom-stacio
branch
from
01308dd to
e602ec6
Compare
philvarner
approved these changes
Mar 6, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 86.24% 87.17% +0.92%
==========================================
Files 11 11
Lines 829 834 +5
==========================================
+ Hits 715 727 +12
+ Misses 114 107 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
headersare ignored when providing a custom StacIO #430Description:
Currently, if a
stac_iois provided toClient.openand friends, the other configuration parameters (e.g.headers) are ignored. This updatesClient.from_fileto update existingstac_ios with headers, parameters, and request modifiers.PR Checklist: