Block network requests during unit tests #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 78.71% 78.71%
=======================================
Files 9 9
Lines 545 545
=======================================
Hits 429 429
Misses 116 116 Continue to review full report at Codecov.
|
gadomski
approved these changes
Nov 11, 2021
matthewhanson
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
None
Description:
While working on #118 I noticed that one of the tests in
test_item_search.pywas taking a while and discovered that it was not using VCR.py/pytest-recordingto record the responses. This PR adds the--block-networkoption to all test commands to ensure that an exception is raised whenever a network request is made and adds the@pytest.mark.vcrdecorator to the offending test.PR Checklist: