Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intervals #363

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Fix intervals #363

merged 4 commits into from
Nov 28, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Nov 28, 2022

Related Issue(s):

Description:

Add some additional checks and fixes to the datetime parsing and interval construction.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski requested a review from philvarner November 28, 2022 18:52
@codecov-commenter
Copy link

Codecov Report

Base: 85.18% // Head: 85.30% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (230d168) compared to base (e45c68d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   85.18%   85.30%   +0.11%     
==========================================
  Files          11       11              
  Lines         790      796       +6     
==========================================
+ Hits          673      679       +6     
  Misses        117      117              
Impacted Files Coverage Δ
pystac_client/item_search.py 92.69% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski merged commit 92ddf38 into main Nov 28, 2022
@gadomski gadomski deleted the issues/357-intervals branch November 28, 2022 20:03
@gadomski gadomski added this to the v0.5.2 milestone Dec 12, 2022
@gadomski gadomski modified the milestones: 0.5.2, 0.6.0 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issues with datetime open interval validation
3 participants