Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windoze and macos in CI #378

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Enable windoze and macos in CI #378

merged 5 commits into from
Jan 19, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Dec 13, 2022

Related Issue(s):

Description:

Once approved, we should enable these checks as required.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG
  • (once approved) Add windoze and macos to required checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Base: 85.30% // Head: 85.50% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (d83978e) compared to base (a7fdec1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   85.30%   85.50%   +0.19%     
==========================================
  Files          11       11              
  Lines         796      800       +4     
==========================================
+ Hits          679      684       +5     
+ Misses        117      116       -1     
Impacted Files Coverage Δ
pystac_client/item_search.py 92.97% <ø> (+0.28%) ⬆️
pystac_client/client.py 85.14% <100.00%> (+0.30%) ⬆️
pystac_client/stac_api_io.py 86.48% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski force-pushed the issues/351-windoze-and-macos branch from 7903798 to d83978e Compare December 13, 2022 20:44
@gadomski gadomski marked this pull request as draft December 13, 2022 22:21
@gadomski gadomski force-pushed the issues/351-windoze-and-macos branch 2 times, most recently from 803a085 to b2d75b3 Compare January 18, 2023 21:39
@gadomski gadomski added this to the 0.5.2 milestone Jan 18, 2023
@gadomski gadomski force-pushed the issues/351-windoze-and-macos branch from b0a999b to 42c6260 Compare January 18, 2023 21:43
@gadomski gadomski marked this pull request as ready for review January 18, 2023 21:43
@gadomski gadomski requested a review from pjhartzell January 18, 2023 21:43
@gadomski gadomski self-assigned this Jan 18, 2023
@pjhartzell
Copy link
Collaborator

Once approved, we should enable these checks as required.

What does this mean?

.github/workflows/continuous-integration.yml Show resolved Hide resolved
pystac_client/stac_api_io.py Show resolved Hide resolved
@gadomski
Copy link
Member Author

What does this mean?

In the repository settings, you can add CI checks as required:

image

If a check isn't required, you can still merge the PR even if the check fails.

@gadomski gadomski merged commit 381d256 into main Jan 19, 2023
@gadomski gadomski deleted the issues/351-windoze-and-macos branch January 19, 2023 15:54
@gadomski gadomski modified the milestones: 0.5.2, 0.6.0 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable windows and macos builds in CI
3 participants