Push max items check down into paging #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
issues/490-paging-with-max-items
branch
from
7d72963 to
5e62cef
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 87.27% 87.30% +0.03%
==========================================
Files 11 11
Lines 833 835 +2
==========================================
+ Hits 727 729 +2
Misses 106 106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gadomski
force-pushed
the
issues/490-paging-with-max-items
branch
from
5e62cef to
f7556b7
Compare
gadomski
commented
Apr 20, 2023
pjhartzell
reviewed
Apr 21, 2023
Required some rewriting of a couple cassettes as the requests changed tightly.
gadomski
force-pushed
the
issues/490-paging-with-max-items
branch
from
f7556b7 to
419f82f
Compare
pjhartzell
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
There's no reason why we can't do our
max_itemscheck while paging, so we do. Also removes some duplicated calls tostac_io.get_pages, so we have a single path to fetching pages.PR Checklist: