Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retries by default #532

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Enable retries by default #532

merged 3 commits into from
Jun 9, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jun 7, 2023

Related Issue(s):

Description:

Turned out to be simpler than I expected. I also added some docs around more complication configuration.

I moved some of the doc sections around to a way that makes more sense than me.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski added this to the 0.7.0 milestone Jun 7, 2023
@gadomski gadomski requested a review from jsignell June 7, 2023 16:41
@gadomski gadomski self-assigned this Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (3dd14fd) 87.99% compared to head (9c195ba) 88.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   87.99%   88.04%   +0.04%     
==========================================
  Files          13       13              
  Lines         991      995       +4     
==========================================
+ Hits          872      876       +4     
  Misses        119      119              
Impacted Files Coverage Δ
pystac_client/stac_api_io.py 91.30% <100.00%> (+0.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one suggestion

docs/usage.rst Show resolved Hide resolved
@gadomski gadomski force-pushed the issues/520-retries branch 2 times, most recently from 07166b7 to 9c195ba Compare June 7, 2023 17:54
@gadomski gadomski force-pushed the issues/520-retries branch from 9c195ba to 6138e11 Compare June 8, 2023 15:23
@gadomski gadomski requested a review from jsignell June 8, 2023 15:23
@gadomski gadomski enabled auto-merge (squash) June 9, 2023 13:26
@gadomski gadomski merged commit 25a2743 into main Jun 9, 2023
@gadomski gadomski deleted the issues/520-retries branch June 9, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for retry configuration in pystac-client and enable them by default
3 participants