Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing_extensions import #541

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Remove typing_extensions import #541

merged 1 commit into from
Jun 13, 2023

Conversation

gadomski
Copy link
Member

Related Issue(s):

Description:
Unneeded

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski added this to the 0.7.1 milestone Jun 13, 2023
@gadomski gadomski self-assigned this Jun 13, 2023
@gadomski gadomski requested a review from pjhartzell June 13, 2023 11:42
@gadomski gadomski enabled auto-merge (squash) June 13, 2023 11:42
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (fdcb8e9) 88.05% compared to head (e32f857) 88.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   88.05%   88.04%   -0.02%     
==========================================
  Files          13       13              
  Lines         996      995       -1     
==========================================
- Hits          877      876       -1     
  Misses        119      119              
Impacted Files Coverage Δ
pystac_client/stac_api_io.py 91.22% <100.00%> (-0.08%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gadomski gadomski merged commit 331d282 into main Jun 13, 2023
@gadomski gadomski deleted the fix-typing-extensions branch June 13, 2023 12:08
@gadomski gadomski mentioned this pull request Jun 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.7 missing typing_extensions module
3 participants