Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the datetime regex #59

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Improve the datetime regex #59

merged 2 commits into from
Jun 6, 2021

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jun 4, 2021

Related Issue(s): #57

Description: Improves the datetime regex. Includes a test with a lot of funky datetimes.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

gadomski added 2 commits June 4, 2021 06:09
Includes a test with a lot of funky datetimes.

Closes #57
@codecov-commenter
Copy link

Codecov Report

Merging #59 (e6dfb22) into main (2aa5ecf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files          13       13           
  Lines         634      634           
=======================================
  Hits          542      542           
  Misses         92       92           
Impacted Files Coverage Δ
pystac_client/item_search.py 80.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa5ecf...e6dfb22. Read the comment docs.

@matthewhanson matthewhanson merged commit 9e66bb5 into stac-utils:main Jun 6, 2021
@gadomski gadomski deleted the issues/57-datetime-regex branch June 7, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants