Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pystac v1.10 #661

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Update to pystac v1.10 #661

merged 2 commits into from
Apr 2, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 2, 2024

Related Issue(s):

Discussion:

Also drops Python 3.8 (because PySTAC did) and add Python 3.12.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG
  • When approved, update the required status checks in Github

@gadomski gadomski requested a review from jsignell April 2, 2024 16:22
@gadomski gadomski self-assigned this Apr 2, 2024
@TomAugspurger
Copy link
Collaborator

Do we need to require pystac>=1.1? I think that's fine with me (otherwise, we'll need to do overloads or something, and have the signature depend on the runtime version of pystac)

@gadomski
Copy link
Member Author

gadomski commented Apr 2, 2024

Do we need to require pystac>=1.1? I think that's fine with me (otherwise, we'll need to do overloads or something, and have the signature depend on the runtime version of pystac)

Yeah, I'm fighting this right now ... I think depending on pystac >= v1.10 is fine, I'll update. Thanks Tom.

@gadomski gadomski changed the title Fix type signature of __init__s for pystac v1.10 Update to pystac v1.10 Apr 2, 2024
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gadomski gadomski merged commit 68e0f6b into main Apr 2, 2024
18 checks passed
@gadomski gadomski deleted the fix-typing branch April 2, 2024 16:52
@gadomski gadomski mentioned this pull request May 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants