Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace str() with repr() in StringEnum & test it (#1369) #1473

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

teks
Copy link
Contributor

@teks teks commented Nov 6, 2024

Related Issue(s):

Description: Simple replacement of str() with repr(). This technically changes the output from a string to a quoted string, eg foo to 'foo'. But I couldn't find any places where it'd matter.

This is such a minor change I wasn't sure whether to add to the changelog; should I?

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski self-requested a review November 6, 2024 01:18
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (b052b2a) to head (8255cb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
+ Coverage   91.15%   91.17%   +0.01%     
==========================================
  Files          52       52              
  Lines        7251     7251              
  Branches      875      875              
==========================================
+ Hits         6610     6611       +1     
+ Misses        461      460       -1     
  Partials      180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a minor change I wasn't sure whether to add to the changelog; should I?

Nah, doesn't need one. Thanks!

@gadomski gadomski added this pull request to the merge queue Nov 6, 2024
Merged via the queue into stac-utils:main with commit 5b72d15 Nov 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

str/repr mixup in StringEnum?
2 participants