Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump mypy from 0.931 to 0.940 #765

Merged
merged 7 commits into from
Mar 17, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 14, 2022

Bumps mypy from 0.931 to 0.940.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python labels Mar 14, 2022
Bumps [mypy](https://github.com/python/mypy) from 0.931 to 0.940.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.931...v0.940)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/mypy-0.940 branch from a95695b to ccc3566 Compare March 14, 2022 14:21
Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing CI for 3.11 is coming from the maturin build of orjson. maturin tries to import tomli and falls back to importing tomllib if that is unavailable. However, maturin only lists tomli as a dependency for python_version<'3.11' here so neither dependency is available at build time. I will open an issue on maturin to address this, but since 3.11 support is experimental, I am approving this PR.

@duckontheweb
Copy link
Contributor

cc: @gadomski

@gadomski
Copy link
Member

Could we install tomli as a workaround to get it passing? Either in CI for the 3.11 build only, or in requirements-dev.txt?

@duckontheweb
Copy link
Contributor

Could we install tomli as a workaround to get it passing? Either in CI for the 3.11 build only, or in requirements-dev.txt?

I opened PyO3/maturin#850 to address this and then almost immediately afterwards came across PEP 680, which adds tomllib to Python 3.11. It seems like this has not yet been implemented in the alpha releases, which is why we are seeing this failure. My preference would be to not patch this so that we know when this install starts to succeed in Python 3.11. @gadomski what do you think?

@duckontheweb
Copy link
Contributor

It looks like maturin changed their build system dependencies about 6 days ago in v0.12.10, which is probably why we're just seeing this.

@duckontheweb
Copy link
Contributor

tomllib has been integrated into CPython on the main branch but won't be in an alpha release until the next scheduled release on Apr. 5 according to pylint-dev/pylint#5920.

Since the changes have been merged and there is a pretty short timeline to the next release I would be okay with patching this by installing tomli for now and then removing that install when we upgrade the 3.11 prerelease version in the CI.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@bcdf2e7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 47f77eb differs from pull request most recent head ad4bd63. Consider uploading reports for the commit ad4bd63 to get more accurate results

@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage        ?   94.55%           
=======================================
  Files           ?       79           
  Lines           ?    11622           
  Branches        ?     1370           
=======================================
  Hits            ?    10989           
  Misses          ?      455           
  Partials        ?      178           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdf2e7...ad4bd63. Read the comment docs.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 15, 2022

A newer version of mypy exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@duckontheweb
Copy link
Contributor

PEP 680

@gadomski Since setuptools creates an isolated build environment, it didn't work to install tomli prior to installing orjson. Similarly, I don't think it will work to install an older version of maturin that avoids the issue because it will also be installed outside of the build environment. I'm inclined to not spend any more time on this and just accept the failures until the next Python 3.11 alpha release is out unless you have another angle you want to try.

@gadomski
Copy link
Member

Yeah, I think it's fine to carry on, that's the whole point of the non-required CI checks eh?

@duckontheweb duckontheweb merged commit a48e2dc into main Mar 17, 2022
@dependabot dependabot bot deleted the dependabot/pip/mypy-0.940 branch March 17, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants