Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to DownloadError #160

Merged
merged 1 commit into from
May 13, 2024
Merged

Add more info to DownloadError #160

merged 1 commit into from
May 13, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 13, 2024

Related issues and pull requests

Description

Before:

An error occurred (AccessDenied) when calling the GetObject operation: Access Denied

After:

ClientError: An error occurred (AccessDenied) when calling the GetObject operation: Access Denied

It's not much, but for (e.g.) stac-utils/stac-task#126 it would have been enough to realize it's a timeout error.

Can't really test.

Checklist

  • Update CHANGELOG

@gadomski gadomski self-assigned this May 13, 2024
@gadomski gadomski force-pushed the issues/159-download-error branch from 69fb873 to c4bbed5 Compare May 13, 2024 14:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (b1f819c) to head (69fb873).

❗ Current head 69fb873 differs from pull request most recent head c4bbed5. Consider uploading reports for the commit c4bbed5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files          16       16           
  Lines         981      981           
=======================================
  Hits          785      785           
  Misses        196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit f30c23f into main May 13, 2024
9 checks passed
@gadomski gadomski deleted the issues/159-download-error branch May 13, 2024 14:26
@gadomski gadomski mentioned this pull request Jul 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the message in DownloadError better
2 participants